linux-kernel - Re: [PATCH v4 4/5] docs: media: document media multi-committers rules and process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83a5bb14-f7f4-4ff5-bb79-098c62fd8fea@xs4all.nl>
Date: Fri, 6 Dec 2024 16:22:06 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [PATCH v4 4/5] docs: media: document media multi-committers rules
 and process

On 05/12/2024 13:36, Hans Verkuil wrote:
> On 03/12/2024 13:29, Laurent Pinchart wrote:
>>
>>> +
>>> +Once the developer accepts being a committer, the new committer shall
>>> +explicitly accept the Kernel development policies described under its
>>> +Documentation/, and, in particular to the rules on this document, by writing
>>> +an e-mail to media-committers@...uxtv.org, with a declaration of intent
>>> +following the model below::
>>> +
>>> +   I, John Doe, would like to change my status to: Committer
>>> +
>>> +   I intend to actively develop the XYZ driver, send fixes to drivers
>>> +   that I can test, optionally reviewing patches and merging trivial
>>> +   fixes in other areas of the subsystem, ...
>>> +
>>> +   For the purpose of committing patches to the media-committer's tree,
>>> +   I'll be using my user https://gitlab.freedesktop.org/users/<username>.
>>> +
>>> +Followed by a formal declaration of agreement with the Kernel development
>>> +rules::
>>> +
>>> +   I hereby declare that I agree with the Kernel development rules described at:
>>
>> Dropping "hereby " ...
> 
> I would just drop the "I hereby declare that " part. It is probably a copy-and-paste
> from somewhere, but it is overly formal.
> 
>>
>>> +
>>> +   https://www.kernel.org/doc/html/latest/driver-api/media/media-committer.rst
>>> +
>>> +   and to the Linux Kernel development process rules.
>>> +
>>> +   I agree to the Code of Conduct as documented in:
>>> +   https://www.kernel.org/doc/html/latest/process/code-of-conduct.rst
>>> +
>>> +   I am aware that I can, at any point of time, retire. In that case, I will
>>> +   send an e-mail to notify the subsystem maintainers for them to revoke my
>>> +   commit rights.
>>> +
>>> +   I am aware that the Kernel development rules change over time.
>>> +   By doing a new push to media-committer tree, I understand that I agree
>>> +   with the rules in effect at the time of the commit.

After looking at https://developercertificate.org/, I would propose to rewrite
this along these lines:

---------------------------------------------------------------------------
By becoming media committer, I certify that:

(a) I agree to the Kernel development rules described at:

	https://www.kernel.org/doc/html/latest/driver-api/media/media-committer.rst

    and to the Linux Kernel development process rules.

(b) I agree to the Code of Conduct as documented in:

	https://www.kernel.org/doc/html/latest/process/code-of-conduct.rst

(c) I am aware that the Kernel development rules change over time.
    By doing a new push to the media-committer tree, I understand that I agree
    with the rules in effect at the time of the commit.
---------------------------------------------------------------------------

I assume that the people who wrote the Developer's Certificate of Origin knew what
they were doing.

Regards,

	Hans