linux-kernel - Re: [PATCH V2] pwm: stm32-lp: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <o6rh2bcxnnubhx6xem55otgequw5zrqmkretcgofohvcpbygdw@z3qagurhjyp3>
Date: Fri, 6 Dec 2024 17:53:08 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Mingwei Zheng <zmw12306@...il.com>
Cc: fabrice.gasnier@...s.st.com, mcoquelin.stm32@...il.com, 
	alexandre.torgue@...s.st.com, hierry.reding@...il.com, lee@...nel.org, 
	linux-pwm@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH V2] pwm: stm32-lp: Add check for clk_enable()

On Fri, Dec 06, 2024 at 08:12:57AM +0100, Uwe Kleine-König wrote:
> On Thu, Dec 05, 2024 at 08:26:05PM -0500, Mingwei Zheng wrote:
> > Add check for the return value of clk_enable() to catch the potential
> > error.
> > 
> > Fixes: e70a540b4e02 ("pwm: Add STM32 LPTimer PWM driver")
> > Signed-off-by: Mingwei Zheng <zmw12306@...il.com>
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
> 
> In reply to (implicit) v1 you wrote:
> > We detected this through static analysis, instead of actually hit.
> 
> Would be nice to mention the tool that actually found it in the commit
> log.
> 
> Otherwise I'm happy with that change now.
> 
> Given the issue is old (the offending commit is in v4.14-rc1), I'd note
> send it as a fix before v4.14. I'd send it along however if something
> more urgent pops up.

I wasn't very attentive when I wrote that mail, what I meant was:

Given the issue is old (the offending commit is in v4.14-rc1), I'd not
send it as a fix before v6.13. I'd send it along however if something
more urgent pops up.

Best regards
Uwe



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)