linux-kernel - Re: [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241206-wrought-jailbreak-52cc4a21a713@spud>
Date: Fri, 6 Dec 2024 16:57:01 +0000
From: Conor Dooley <conor@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY

On Fri, Dec 06, 2024 at 09:10:14AM +0100, Oleksij Rempel wrote:
> On Thu, Dec 05, 2024 at 05:18:59PM +0000, Conor Dooley wrote:
> > On Thu, Dec 05, 2024 at 01:56:36PM +0100, Oleksij Rempel wrote:
> > > Introduce devicetree binding for the Texas Instruments DP83TD510
> > > Ultra Low Power 802.3cg 10Base-T1L Single Pair Ethernet PHY.
> > > 
> > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > > ---
> > >  .../devicetree/bindings/net/ti,dp83td510.yaml | 35 +++++++++++++++++++
> > >  1 file changed, 35 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/ti,dp83td510.yaml b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > new file mode 100644
> > > index 000000000000..cf13e86a4017
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > @@ -0,0 +1,35 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/net/ti,dp83td510.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: TI DP83TD510 10BaseT1L PHY
> > > +
> > > +maintainers:
> > > +  - Oleksij Rempel <o.rempel@...gutronix.de>
> > > +
> > > +description:
> > > +  DP83TD510E Ultra Low Power 802.3cg 10Base-T1L 10M Single Pair Ethernet PHY
> > > +
> > > +allOf:
> > > +  - $ref: ethernet-phy.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - ethernet-phy-id2000.0181
> > 
> > There's nothing specific here, can someone remind me why the generic
> > binding is not enough?
> 
> The missing binding was blamed by checkpatch. Haw should I proceed with this
> patch?

Does dtbs_check complain when you use it in a dts? What you have here
matches against the pattern ^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$
so I think it won't. checkpatch might be too dumb to evaluate the regex?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)