linux-kernel - Re: [PATCH v7 4/5] arm64: dts: qcom: sc7280: Add support for camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <106b1945-e288-4522-8567-90cadcbc9148@quicinc.com>
Date: Sat, 7 Dec 2024 00:57:50 +0530
From: Vikram Sharma <quic_vikramsa@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <bryan.odonoghue@...aro.org>,
        <mchehab@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <akapatra@...cinc.com>, <hariramp@...cinc.com>,
        <andersson@...nel.org>, <konradybcio@...nel.org>,
        <hverkuil-cisco@...all.nl>, <cros-qcom-dts-watchers@...omium.org>,
        <catalin.marinas@....com>, <will@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>
Subject: Re: [PATCH v7 4/5] arm64: dts: qcom: sc7280: Add support for camss


On 12/5/2024 9:58 PM, Konrad Dybcio wrote:
> On 4.12.2024 11:00 AM, Vikram Sharma wrote:
>> Add changes to support the camera subsystem on the SC7280.
>>
>> Signed-off-by: Suresh Vankadara <quic_svankada@...cinc.com>
>> Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@...cinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
>> ---
> [...]
>
> (isp@ as mentioned)
Hi Konrad,

Thanks for your review and comments.
I have posted V8 addressing these comments.

Best Regards,
Vikram

>
>> +			interconnects = <&gem_noc  MASTER_APPSS_PROC 0 &cnoc2 SLAVE_CAMERA_CFG 0>,
> QCOM_ICC_TAG_ACTIVE_ONLY
>
>> +					<&mmss_noc MASTER_CAMNOC_HF  0 &mc_virt SLAVE_EBI1     0>;
> QCOM_ICC_TAG_ALWAYS
>
>> +			interconnect-names = "ahb", "hf_0";
>> +
>> +			iommus = <&apps_smmu 0x800 0x4e0>;
>> +
>> +			power-domains = <&camcc CAM_CC_IFE_0_GDSC>,
>> +					<&camcc CAM_CC_IFE_1_GDSC>,
>> +					<&camcc CAM_CC_IFE_2_GDSC>,
>> +					<&camcc CAM_CC_TITAN_TOP_GDSC>;
>> +			power-domain-names = "ife0", "ife1", "ife2", "top";
> vertical list, please
>
> Konrad