linux-kernel - Re: [PATCH next] btrfs: selftests: prevent error pointer dereference in merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241206193534.GK31418@twin.jikos.cz>
Date: Fri, 6 Dec 2024 20:35:34 +0100
From: David Sterba <dsterba@...e.cz>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Josef Bacik <josef@...icpanda.com>, Chris Mason <clm@...com>,
	David Sterba <dsterba@...e.com>, Boris Burkov <boris@....io>,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] btrfs: selftests: prevent error pointer dereference
 in merge_tests()

On Fri, Dec 06, 2024 at 03:26:14PM +0300, Dan Carpenter wrote:
> Passing an error pointer to btrfs_unselect_ref_head() will cause an
> Oops so change the error checking from a NULL check to a
> !IS_ERR_OR_NULL(head) check.
> 
> The error pointer comes from btrfs_select_ref_head().  If we
> successfully select the head, then we have to unselect it.  The select
> function is called six times and five of them change the error pointers
> to NULL, but one call was accidentally missed.
> 
> Fixes: fa3dda44871b ("btrfs: selftests: add delayed ref self test cases")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks, as the fixed patch is still in the development queue I've folded
it there.