linux-kernel - Re: [PATCH] mseal: remove can_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALmYWFvk75iP3Hha-4-UfwwToSH=Qg=trAhOCqH_t4F2oW4yQA@mail.gmail.com>
Date: Fri, 6 Dec 2024 11:37:18 -0800
From: Jeff Xu <jeffxu@...gle.com>
To: jeffxu@...omium.org
Cc: akpm@...ux-foundation.org, vbabka@...e.cz, lorenzo.stoakes@...cle.com, 
	Liam.Howlett@...cle.com, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org, linux-mm@...ck.org, jorgelo@...omium.org, 
	keescook@...omium.org, pedro.falcato@...il.com, rdunlap@...radead.org
Subject: Re: [PATCH] mseal: remove can_do_mseal

On Fri, Dec 6, 2024 at 11:33 AM <jeffxu@...omium.org> wrote:
>
> From: Jeff Xu <jeffxu@...gle.com>
>
> Hi Andrew,
>
> Is that possible to squash this change on top of
> "mseal: move can_do_mseal to mseal.c" on the mm-unstable ?
>
> This is the first time I m doing this, because I saw dev did this before,
> and saying this is the prefered approach.
>
> I could also send v2 which is what I usually do.
>
Actually, please ignore this, I will send a V2 instead.
(this didn't remove the code, sorry about that)

> Thanks
> -Jeff
>
> Signed-off-by: Jeff Xu <jeffxu@...omium.org>
> ---
>  mm/mseal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/mseal.c b/mm/mseal.c
> index e167220a0bf0..08e6f328d9c7 100644
> --- a/mm/mseal.c
> +++ b/mm/mseal.c
> @@ -225,9 +225,9 @@ int do_mseal(unsigned long start, size_t len_in, unsigned long flags)
>         unsigned long end;
>         struct mm_struct *mm = current->mm;
>
> -       ret = can_do_mseal(flags);
> -       if (ret)
> -               return ret;
> +       /* Verify flags not set. */
> +       if (flags)
> +               return -EINVAL;
>
>         start = untagged_addr(start);
>         if (!PAGE_ALIGNED(start))
> --
> 2.47.0.338.g60cca15819-goog
>