linux-kernel - Re: [PATCH V4 RESEND net-next 6/7] net: hibmcge: Add reset supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241205175916.07d50c71@kernel.org>
Date: Thu, 5 Dec 2024 17:59:16 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <andrew+netdev@...n.ch>, <horms@...nel.org>, <shenjian15@...wei.com>,
 <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
 <chenhao418@...wei.com>, <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
 <shiyongbang@...wei.com>, <libaihan@...wei.com>,
 <jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
 <salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <hkelam@...vell.com>
Subject: Re: [PATCH V4 RESEND net-next 6/7] net: hibmcge: Add reset
 supported in this module

On Tue, 3 Dec 2024 23:01:30 +0800 Jijie Shao wrote:
> But the ethtool command already holds the rtnl lock in the dev_ethtool().
> So, the reset operation is not directly performed in
> ethtool_ops.reset() function. Instead, the reset operation
> is triggered by a scheduled task.

You can trivially factor out taking and releasing of the lock so that
ethtool path can execute just the logic inside, no?