linux-kernel - RE: [PATCH v7 3/3] clk: aspeed: add AST2700 clock driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c898338622625cbfc825e8d4cc5f0fff.sboyd@kernel.org>
Date: Fri, 06 Dec 2024 14:15:47 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Ryan Chen <ryan_chen@...eedtech.com>, andrew@...econstruct.com.au, conor+dt@...nel.org, devicetree@...r.kernel.org, dmitry.baryshkov@...aro.org, joel@....id.au, krzk+dt@...nel.org, lee@...nel.org, linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, mturquette@...libre.com, p.zabel@...gutronix.de, robh@...nel.org
Subject: RE: [PATCH v7 3/3] clk: aspeed: add AST2700 clock driver.

Quoting Ryan Chen (2024-12-04 16:48:42)
> > > struct ast2700_clk_info {
> > >         const char *name;
> > >         u8 clk_idx;
> > >         u32 reg;
> > >         u32 type;
> > >         union {
> > >                 struct ast2700_clk_fixed_factor_data factor;
> > >                 struct ast2700_clk_fixed_rate_data rate;
> > >                 struct ast2700_clk_gate_data gate;
> > >                 struct ast2700_clk_div_data div;
> > >                 struct ast2700_clk_pll_data pll;
> > >                 struct ast2700_clk_mux_data mux;
> > >         } data;
> > > };
> > >
> > > struct ast2700_clk_div_data {
> > >         const struct clk_div_table *div_table;
> > >         const struct clk_parent_data *parent;
> > >         u8 bit_shift;
> > >         u8 bit_width;
> > >         u32 reg;
> > > };
> > >
> > > static const struct ast2700_clk_info ast2700_scu0_clk_info[]
> > > __initconst = { ...........................
> > >         DIVIDER_CLK(SCU0_CLK_AHB, "soc0-ahb", soc0_ahbmux,
> > 
> > Can you also show what soc0_ahbmux is?
> It will be following. 
> 
> static const struct clk_parent_data soc0_ahbmux[] = {
>         { .fw_name = "soc0-ahbmux", .name = "soc0-ahbmux" },
> };

Instead of that, please use only the index.

 static const struct clk_parent_data soc0_ahbmux[] = {
         { .index = <number from DT binding> },
 };