linux-kernel - Re: [PATCH] wifi: ath11k: allow APs combination when dual stations are supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f24e115-e76d-4c8a-8a1b-591a157ee78e@quicinc.com>
Date: Fri, 6 Dec 2024 10:24:32 +0800
From: "Yu Zhang (Yuriy)" <quic_yuzha@...cinc.com>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
CC: <ath11k@...ts.infradead.org>, <jjohnson@...nel.org>, <kvalo@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
        <quic_cjhuang@...cinc.com>, <vbenes@...hat.com>
Subject: Re: [PATCH] wifi: ath11k: allow APs combination when dual stations
 are supported



On 12/5/2024 7:07 PM, Jose Ignacio Tornos Martinez wrote:
>> But I see your interfaces all be added with managed， right?
> Yes
> 
My point is that you can try setup with ap type interface, now 
combination limits not allow up 3 inferfaces with managed interface.
>> Test steps:
>> ...
> Ok, I am using a bridge with the AP interfaces in addition but it is
> the same.
> Indeed I have tested in the same way as you too (even using your
> hostapd.conf with the suitable name for the interfaces).
> So I have started to debug (current upstream linux +
> https://lore.kernel.org/all/20241127022742.4016870-1-quic_yuzha@quicinc.com/ +
> dump_stack() in ath11k_mac_op_add_interface, enabling ath11k_dbg),
> let me show you this:
> [    5.703295] ath11k_pci 0000:01:00.0: vdev a2:d8:da:c5:7b:79 created, vdev_id 0
> [    5.703304] CPU: 4 UID: 0 PID: 945 Comm: NetworkManager Tainted: G        W          6.12.0+ #104
> [    5.703315] Tainted: [W]=WARN
> [    5.703317] Hardware name: ASUS System Product Name/PRIME B660-PLUS D4, BIOS 1620 08/12/2022
> [    5.703320] Call Trace:
> [    5.703325]  <TASK>
> [    5.703330]  dump_stack_lvl+0x5d/0x80
> [    5.703344]  ath11k_mac_op_add_interface.cold+0x4ed/0xa92 [ath11k]
> [    5.703399]  drv_add_interface+0x4f/0x230 [mac80211]
> [    5.703512]  ieee80211_do_open+0x4b3/0x770 [mac80211]
> [    5.703669]  ieee80211_open+0x8a/0x90 [mac80211]
> ...
> [    5.804755] ath11k_pci 0000:01:00.0: vdev c8:94:02:b5:fe:fb created, vdev_id 1
> [    5.804759] CPU: 1 UID: 0 PID: 1011 Comm: wpa_supplicant Tainted: G        W          6.12.0+ #104
> [    5.804763] Tainted: [W]=WARN
> [    5.804765] Hardware name: ASUS System Product Name/PRIME B660-PLUS D4, BIOS 1620 08/12/2022
> [    5.804766] Call Trace:
> [    5.804770]  <TASK>
> [    5.804773]  dump_stack_lvl+0x5d/0x80
> [    5.804783]  ath11k_mac_op_add_interface.cold+0x4ed/0xa92 [ath11k]
> [    5.804809]  drv_add_interface+0x4f/0x230 [mac80211]
> [    5.804868]  ieee80211_do_open+0x4b3/0x770 [mac80211]
> [    5.804934]  nl80211_start_p2p_device+0x8b/0x160 [cfg80211]
> ...
> So, since the normal sta interface and p2p interface are initialized,
> with your proposed interface combination, only one AP interface can be
> added for me (vdev limit is 3).
> I like your idea to have a common interface combination set for everything,
> but I think it is not possible here.
> My patch with the new parameter at least allow to select what to do, dual
> stations support or APs support for all the cases.
> 
> Thanks
> 
> Best regards
> Jose Ignacio
>