linux-kernel - Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support for sm8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38dd7991-8503-44af-8400-cbe6a8968213@quicinc.com>
Date: Fri, 6 Dec 2024 10:31:58 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <vladimir.zapolskiy@...aro.org>
CC: <quic_eberman@...cinc.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>,
        Yongsheng Li
	<quic_yon@...cinc.com>
Subject: Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support for sm8550

Hi Bryan,

On 12/6/2024 8:14 AM, Bryan O'Donoghue wrote:
> Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support for sm8550
> 
> Please drop sm8550 in your patch title, change it to something more 
> consistent with the VFE patch title i.e. your next patch.
> 

Sure, will drop sm8550 in the title.

>> +++ b/drivers/media/platform/qcom/camss/camss-csid-780.h
>> @@ -0,0 +1,25 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * camss-csid-780.h
>> + *
>> + * Qualcomm MSM Camera Subsystem - CSID (CSI Decoder) Module 
>> Generation 3
>> + *
>> + * Copyright (c) 2024 Qualcomm Technologies, Inc.
>> + */
>> +#ifndef QC_MSM_CAMSS_CSID_780_H
>> +#define QC_MSM_CAMSS_CSID_780_H
> 
> #ifndef __CAMSS_CSID_780_H__ or __QC_MSM_CAMSS_CSID_780_H__
> 
> Either way please encapsulate your guard __thus__
> 
> Same comment for all new headers added in this series.
> 

Thanks for the comments, I will check the other headers in this series 
and update them based on suggestion.

Thanks,
Depeng