linux-kernel - RE: [PATCH v2 0/2] Drivers: hv: util: Two fixes in util

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BN7PR02MB41484EF2CF3F0C31BE6F4E4CD4312@BN7PR02MB4148.namprd02.prod.outlook.com>
Date: Fri, 6 Dec 2024 02:44:40 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Michael Kelley <mhklinux@...look.com>, "kys@...rosoft.com"
	<kys@...rosoft.com>, "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>, "decui@...rosoft.com"
	<decui@...rosoft.com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "vkuznets@...hat.com" <vkuznets@...hat.com>
CC: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 0/2] Drivers: hv: util: Two fixes in util_probe()

From: mhkelley58@...il.com <mhkelley58@...il.com> Sent: Wednesday, November 6, 2024 7:43 AM
> 
> Patch 1 fixes util_probe() to not force the error return value to
> ENODEV when the util_init function fails -- just return the error
> code from util_init so the real error code is displayed in messages.
> 
> Patch 2 fixes a more serious race condition between initialization
> of the VMBus channel and initial operations of the user space
> daemons for KVP and VSS. The fix reorders the initialization in
> util_probe() so the race condition can't happen.
> 
> The two fixes are functionally independent, but Patch 2 introduces
> the util_init_transport function that parallels the existing code
> for the util_init function. Doing Patch 1 first avoids an
> inconsistency in the error handling in similar code for these two
> parts of util_probe().
> 
> This series is v2 of a single patch first posted by Dexuan Cui
> to fix the race condition.[1] I've taken over the patch per
> discussion with Dexuan.
> 
> [1] https://lore.kernel.org/linux-hyperv/20240909164719.41000-1-decui@microsoft.com/
> 

Gentle ping. :-)

Is anyone in the Linux-on-Hyper-V community able to review this short
patch series?  It's pretty straightforward ....

Michael

> Michael Kelley (2):
>   Drivers: hv: util: Don't force error code to ENODEV in util_probe()
>   Drivers: hv: util: Avoid accessing a ringbuffer not initialized yet
> 
>  drivers/hv/hv_kvp.c       |  6 ++++++
>  drivers/hv/hv_snapshot.c  |  6 ++++++
>  drivers/hv/hv_util.c      | 13 ++++++++++---
>  drivers/hv/hyperv_vmbus.h |  2 ++
>  include/linux/hyperv.h    |  1 +
>  5 files changed, 25 insertions(+), 3 deletions(-)
> 
> --
> 2.25.1
>