linux-kernel - Re: [PATCH 10/15] cpufreq/amd-pstate: Move limit updating code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412061054.cJTnhP0n-lkp@intel.com>
Date: Fri, 6 Dec 2024 11:10:52 +0800
From: kernel test robot <lkp@...el.com>
To: Mario Limonciello <mario.limonciello@....com>,
	"Gautham R . Shenoy" <gautham.shenoy@....com>
Cc: oe-kbuild-all@...ts.linux.dev, Perry Yuan <perry.yuan@....com>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>,
	Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH 10/15] cpufreq/amd-pstate: Move limit updating code

Hi Mario,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ab9e5b2eb56412cb8c63b46b935878d29205418e]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/cpufreq-amd-pstate-Add-trace-event-for-EPP-perf-updates/20241206-063920
base:   ab9e5b2eb56412cb8c63b46b935878d29205418e
patch link:    https://lore.kernel.org/r/20241205222847.7889-11-mario.limonciello%40amd.com
patch subject: [PATCH 10/15] cpufreq/amd-pstate: Move limit updating code
config: x86_64-buildonly-randconfig-001-20241206 (https://download.01.org/0day-ci/archive/20241206/202412061054.cJTnhP0n-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241206/202412061054.cJTnhP0n-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412061054.cJTnhP0n-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/cpufreq/amd-pstate.c: In function 'amd_pstate_update_min_max_limit':
>> drivers/cpufreq/amd-pstate.c:606:45: warning: variable 'lowest_perf' set but not used [-Wunused-but-set-variable]
     606 |         u32 max_limit_perf, min_limit_perf, lowest_perf, max_perf, max_freq;
         |                                             ^~~~~~~~~~~


vim +/lowest_perf +606 drivers/cpufreq/amd-pstate.c

ec437d71db77a18 Huang Rui         2021-12-24  603  
febab20caebac95 Wyes Karny        2023-11-17  604  static int amd_pstate_update_min_max_limit(struct cpufreq_policy *policy)
febab20caebac95 Wyes Karny        2023-11-17  605  {
b623ceabb704d2d Mario Limonciello 2024-12-05 @606  	u32 max_limit_perf, min_limit_perf, lowest_perf, max_perf, max_freq;
febab20caebac95 Wyes Karny        2023-11-17  607  	struct amd_cpudata *cpudata = policy->driver_data;
febab20caebac95 Wyes Karny        2023-11-17  608  
18d9b5227121389 Mario Limonciello 2024-10-12  609  	max_perf = READ_ONCE(cpudata->highest_perf);
b623ceabb704d2d Mario Limonciello 2024-12-05  610  	max_freq = READ_ONCE(cpudata->max_freq);
b623ceabb704d2d Mario Limonciello 2024-12-05  611  	max_limit_perf = div_u64(policy->max * max_perf, max_freq);
b623ceabb704d2d Mario Limonciello 2024-12-05  612  	min_limit_perf = div_u64(policy->min * max_perf, max_freq);
febab20caebac95 Wyes Karny        2023-11-17  613  
8164f743326404f Meng Li           2024-02-27  614  	lowest_perf = READ_ONCE(cpudata->lowest_perf);
8164f743326404f Meng Li           2024-02-27  615  
6fbd2a2609d0033 Mario Limonciello 2024-12-05  616  	if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE)
6fbd2a2609d0033 Mario Limonciello 2024-12-05  617  		min_limit_perf = min(cpudata->nominal_perf, max_limit_perf);
8164f743326404f Meng Li           2024-02-27  618  
febab20caebac95 Wyes Karny        2023-11-17  619  	WRITE_ONCE(cpudata->max_limit_perf, max_limit_perf);
febab20caebac95 Wyes Karny        2023-11-17  620  	WRITE_ONCE(cpudata->min_limit_perf, min_limit_perf);
febab20caebac95 Wyes Karny        2023-11-17  621  	WRITE_ONCE(cpudata->max_limit_freq, policy->max);
febab20caebac95 Wyes Karny        2023-11-17  622  	WRITE_ONCE(cpudata->min_limit_freq, policy->min);
febab20caebac95 Wyes Karny        2023-11-17  623  
febab20caebac95 Wyes Karny        2023-11-17  624  	return 0;
febab20caebac95 Wyes Karny        2023-11-17  625  }
febab20caebac95 Wyes Karny        2023-11-17  626  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki