[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z1KWxCmJ2KnrbSPH@BLRRASHENOY1.amd.com>
Date: Fri, 6 Dec 2024 11:46:36 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@....com>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Perry Yuan <perry.yuan@....com>, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org,
Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
Subject: Re: [PATCH 03/15] cpufreq/amd-pstate: Drop cached epp_policy variable
On Thu, Dec 05, 2024 at 04:28:35PM -0600, Mario Limonciello wrote:
> epp_policy is not used by any of the current code and there
> is no need to cache it.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
Looks good to me.
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@....com>
--
Thanks and Regards
gautham.
> ---
> drivers/cpufreq/amd-pstate.c | 3 ---
> drivers/cpufreq/amd-pstate.h | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 7eb013585df51..22e212ca514c5 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1476,7 +1476,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
> return -ENOMEM;
>
> cpudata->cpu = policy->cpu;
> - cpudata->epp_policy = 0;
>
> ret = amd_pstate_init_perf(cpudata);
> if (ret)
> @@ -1583,8 +1582,6 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy)
> value &= ~AMD_CPPC_DES_PERF(~0L);
> value |= AMD_CPPC_DES_PERF(0);
>
> - cpudata->epp_policy = cpudata->policy;
> -
> /* Get BIOS pre-defined epp value */
> epp = amd_pstate_get_epp(cpudata, value);
> if (epp < 0) {
> diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
> index cd573bc6b6db8..7765c82f975c6 100644
> --- a/drivers/cpufreq/amd-pstate.h
> +++ b/drivers/cpufreq/amd-pstate.h
> @@ -57,7 +57,6 @@ struct amd_aperf_mperf {
> * @hw_prefcore: check whether HW supports preferred core featue.
> * Only when hw_prefcore and early prefcore param are true,
> * AMD P-State driver supports preferred core featue.
> - * @epp_policy: Last saved policy used to set energy-performance preference
> * @epp_cached: Cached CPPC energy-performance preference value
> * @policy: Cpufreq policy value
> * @cppc_cap1_cached Cached MSR_AMD_CPPC_CAP1 register value
> @@ -94,7 +93,6 @@ struct amd_cpudata {
> bool hw_prefcore;
>
> /* EPP feature related attributes*/
> - s16 epp_policy;
> s16 epp_cached;
> u32 policy;
> u64 cppc_cap1_cached;
> --
> 2.43.0
>
Powered by blists - more mailing lists