linux-kernel - Re: [PATCH] sample/acrn: Remove redundant assignment to itself

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024120627-debtor-guise-2275@gregkh>
Date: Fri, 6 Dec 2024 07:22:03 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: liujing <liujing@...s.chinamobile.com>
Cc: thorsten.blum@...lux.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sample/acrn: Remove redundant assignment to itself

On Fri, Dec 06, 2024 at 10:41:27AM +0800, liujing wrote:
> Delete the self-redundancy assignment for sig, argc, and argv.

But perhaps they are there for a reason?

> Signed-off-by: liujing <liujing@...s.chinamobile.com>
> 
> diff --git a/samples/acrn/vm-sample.c b/samples/acrn/vm-sample.c
> index c61e0f91456e..f6d62d1659ef 100644
> --- a/samples/acrn/vm-sample.c
> +++ b/samples/acrn/vm-sample.c
> @@ -34,7 +34,6 @@ int is_running = 1;
>  
>  void vm_exit(int sig)
>  {
> -	sig = sig;
>  
>  	is_running = 0;
>  	ioctl(hsm_fd, ACRN_IOCTL_PAUSE_VM, vmid);
> @@ -50,8 +49,6 @@ int main(int argc, char **argv)
>  	struct acrn_io_request *io_req;
>  	struct acrn_ioreq_notify __attribute__((aligned(8))) notify;
>  
> -	argc = argc;
> -	argv = argv;

If you remove these, odds are now you will have build errors/warnings,
right?  That's why someone added these.

sorry,

greg k-h