linux-kernel - Re: [PATCH v3 net] net/mlx5: DR, prevent potential error pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173346902878.2224618.10793227255056593351.git-patchwork-notify@kernel.org>
Date: Fri, 06 Dec 2024 07:10:28 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: kliteyn@...dia.com, saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, muhammads@...dia.com,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v3 net] net/mlx5: DR, prevent potential error pointer
 dereference

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 4 Dec 2024 15:06:41 +0300 you wrote:
> The dr_domain_add_vport_cap() function generally returns NULL on error
> but sometimes we want it to return ERR_PTR(-EBUSY) so the caller can
> retry.  The problem here is that "ret" can be either -EBUSY or -ENOMEM
> and if it's and -ENOMEM then the error pointer is propogated back and
> eventually dereferenced in dr_ste_v0_build_src_gvmi_qpn_tag().
> 
> Fixes: 11a45def2e19 ("net/mlx5: DR, Add support for SF vports")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> [...]

Here is the summary with links:
  - [v3,net] net/mlx5: DR, prevent potential error pointer dereference
    https://git.kernel.org/netdev/net/c/11776cff0b56

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html