linux-kernel - Re: [PATCH] hwmon: tps25990: Fix unreachable code in tps25990_read_word

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fa164c7-5562-40bf-b2d9-92ed1efaff8a@roeck-us.net>
Date: Thu, 5 Dec 2024 16:15:49 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Karol Przybylski <karprzy7@...il.com>
Cc: skhan@...uxfoundation.org, jbrunet@...libre.com, jdelvare@...e.com,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: tps25990: Fix unreachable code in
 tps25990_read_word_data

On Thu, Dec 05, 2024 at 10:33:15PM +0100, Karol Przybylski wrote:
> The tps25990_read_word_data function contains a block of unreachable code caused by the syntactic structure in the PMBUS_VIRT_READ_IIN_MAX case.
> 
> Specifically, the return TPS25990_READ_IIN_PEAK; statement immediately exits the function, making the next lines unreachable.
> 
> This patch removes the return statement, leaving the expected handling.
> 
> Discovered in coverity: CID 1602227
> 
> Signed-off-by: Karol Przybylski <karprzy7@...il.com>

Thanks a log for the patch. I squashed it into the patch introducing the
problem. Please note that the above commit message is missing line breaks.

Thanks,
Guenter