linux-kernel - Re: [PATCH v3 07/15] media: i2c: ds90ub960: Add support for I2C_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9db5211f-c382-4bba-9664-29b788b124d6@ideasonboard.com>
Date: Fri, 6 Dec 2024 09:24:54 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Hans Verkuil <hverkuil-cisco@...all.nl>,
 Jai Luthra <jai.luthra@...asonboard.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 07/15] media: i2c: ds90ub960: Add support for I2C_RX_ID

On 05/12/2024 21:36, Andy Shevchenko wrote:
> On Thu, Dec 05, 2024 at 03:59:58PM +0200, Tomi Valkeinen wrote:
>> On 05/12/2024 10:31, Andy Shevchenko wrote:
>>> On Wed, Dec 04, 2024 at 01:05:21PM +0200, Tomi Valkeinen wrote:
> 
> ...
> 
>>>>    #define MHZ(v) ((u32)((v) * 1000000U))
>>>
>>> Missed HZ_PER_MHZ from previous patch?
>>
>> Yes, and no. I did leave the MHZ uses on purpose. I think the use of
>> HZ_PER_MHZ was fine in the calculations, but when having table-ish use of
>> MHZ, with hardcoded numbers, I found the MHZ() macro much nicer to read:
>>
>> 	case MHZ(1200):
>>
>> vs.
>> 	case 1200 * HZ_PER_MHZ:
> 
> Had I talked about tables? :-)
> I was only commented the calculations.

I see your point now =)

  Tomi