linux-kernel - Re: ucounts: Move kfree() out of critical zone protected by ucounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1733470207-23473-1-git-send-email-mengensun@tencent.com>
Date: Fri,  6 Dec 2024 15:30:07 +0800
From: MengEn Sun <mengensun88@...il.com>
To: visitorckw@...il.com
Cc: akpm@...ux-foundation.org,
	avagin@...gle.com,
	joel.granados@...nel.org,
	linux-kernel@...r.kernel.org,
	linux@...ssschuh.net,
	mengensun88@...il.com,
	mengensun@...cent.com
Subject: Re: ucounts: Move kfree() out of critical zone protected by ucounts_lock

Hi Kuan Wei

On Fri, 6 Dec 2024 13:55:51 +0800 visitorckw@...il.com wrote:
> Hi MengEn,
> 
> On Fri, Dec 06, 2024 at 12:13:47PM +0800, mengensun88@...il.com wrote:
> > From: MengEn Sun <mengensun@...cent.com>
> > 
> > Although kfree is a non-sleep function, it is possible to enter a
> > long chain of calls probabilistically, so it looks better to move
> > kfree from alloc_ucounts() out of the critical zone of ucounts_lock.
> > 
> > Reviewed-by: YueHong Wu <yuehongwu@...cent.com>
> > Signed-off-by: MengEn Sun <mengensun@...cent.com>
> > ---
> >  kernel/ucount.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> It's a common convention to prefix your subject line with [PATCH] to
> let others know it's a patch. Additionally, when resending a patch
> without changes, consider adding RESEND to the subject line, e.g.,
> [PATCH RESEND] ucounts: Move kfree() out of critical zone protected by
> ucounts_lock.

Thank you very much for your reply. I will make some changes here.

> 
> See: https://www.kernel.org/doc/html/v6.12/process/submitting-patches.html#include-patch-in-the-subject

I will study this document carefully.

> 
> Regards,
> Kuan-Wei

Regards,
Meng En