linux-kernel - Re: [PATCH hwmon-next] hwmon: (pmbus/tps25990) Remove unnecessary call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57aa83c3-c063-44f7-ba66-c252e3984aa7@roeck-us.net>
Date: Thu, 5 Dec 2024 23:57:37 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@...il.com>,
 jbrunet@...libre.com, linux-hwmon@...r.kernel.org
Cc: jdelvare@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH hwmon-next] hwmon: (pmbus/tps25990) Remove unnecessary
 call

Hi,

On 12/5/24 22:28, Dheeraj Reddy Jonnalagadda wrote:
> This commit addresses a structurally dead code issue detected by
> Coverity (CID 1602227). An integer is returned early in one of the
> switch cases causing the later statements to never be called. The
> return statement is removed following convention in the other switch
> cases.
> 
> Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@...il.com>

This has already been fixed.

Thanks,
Guenter

> ---
>   drivers/hwmon/pmbus/tps25990.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c
> index cc0f5c7cecb0..0d2655e69549 100644
> --- a/drivers/hwmon/pmbus/tps25990.c
> +++ b/drivers/hwmon/pmbus/tps25990.c
> @@ -130,7 +130,6 @@ static int tps25990_read_word_data(struct i2c_client *client,
>   		break;
>   
>   	case PMBUS_VIRT_READ_IIN_MAX:
> -		return TPS25990_READ_IIN_PEAK;
>   		ret = pmbus_read_word_data(client, page, phase,
>   					   TPS25990_READ_IIN_PEAK);
>   		break;