linux-kernel - Re: [PATCH] dt-bindings: input: convert dlg,da7280.txt to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d1ba835-354b-48d3-83fa-a3e70992e57e@linaro.org>
Date: Fri, 6 Dec 2024 09:24:35 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Conor Dooley <conor@...nel.org>
Cc: Support Opensource <support.opensource@...semi.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Roy Im <roy.im.opensource@...semi.com>,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: input: convert dlg,da7280.txt to dt-schema

Hi Conor,

On 04/12/2024 18:55, Conor Dooley wrote:
> On Wed, Dec 04, 2024 at 11:54:35AM +0100, Neil Armstrong wrote:
> 
>> +  dlg,bemf-sens-enable:
>> +    type: boolean
>> +    description:
>> +      Enable for internal loop computations
>> +
>> +  dlg,freq-track-enable:
>> +    type: boolean
>> +    description:
>> +      Enable for resonant frequency tracking
>> +
>> +  dlg,acc-enable:
>> +    type: boolean
>> +    description:
>> +      Enable for active acceleration
>> +
>> +  dlg,rapid-stop-enable:
>> +    type: boolean
>> +    description:
>> +      Enable for rapid stop
>> +
>> +  dlg,amp-pid-enable:
>> +    type: boolean
> 
> Shouldn't these ones be "flag"?

Yes, I'll switch to it

> 
>> +    description:
>> +      Enable for the amplitude PID
>> +
>> +  dlg,mem-array:
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    minItems: 100
>> +    description:
>> +      Customized waveform memory (patterns) data downloaded to the device during initialization
>> +
>> +required:
>> +  - compatible
> 
> Is this right? The text binding has: compatible, reg, interrupt-parent,
> and a handful of vendor properties required. I don't see a mention for
> the drop in the commit message.

Damn I focused on all the other parts and forgot about the required...

Thanks,
Will fix this in v2.

Neil

> 
> Cheers,
> Conor.
> 
>