| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241206-ub9xx-fixes-v4-11-466786eec7cc@ideasonboard.com> Date: Fri, 06 Dec 2024 10:26:47 +0200 From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com> To: Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Hans Verkuil <hverkuil-cisco@...all.nl>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jai Luthra <jai.luthra@...asonboard.com> Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Tomi Valkeinen <tomi.valkeinen@...asonboard.com> Subject: [PATCH v4 11/15] media: i2c: ds90ub960: Reduce sleep in ub960_rxport_wait_locks() We currently sleep for 50 ms at the end of each iteration in ub960_rxport_wait_locks(). This feels a bit excessive, especially as we always do at least two loops, so there's always at least one sleep, even if we already have a stable lock. Change the sleep to 10 ms. Reviewed-by: Jai Luthra <jai.luthra@...asonboard.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com> --- drivers/media/i2c/ds90ub960.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 51b4aead6ac6..8e8cda4475af 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -1576,7 +1576,12 @@ static int ub960_rxport_wait_locks(struct ub960_data *priv, if (missing == 0) break; - msleep(50); + /* + * The sleep time of 10 ms was found by testing to give a lock + * with a few iterations. It can be decreased if on some setups + * the lock can be achieved much faster. + */ + fsleep(10 * USEC_PER_MSEC); } if (lock_mask) -- 2.43.0
Powered by blists - more mailing lists