linux-kernel - Re: [PATCH v2 06/10] perf/amd/ibs: Add pmu specific minimum period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89d37e39-a513-44d0-9e7e-d705853e6d39@amd.com>
Date: Fri, 6 Dec 2024 14:17:57 +0530
From: Ravi Bangoria <ravi.bangoria@....com>
To: Ingo Molnar <mingo@...nel.org>
Cc: peterz@...radead.org, mingo@...hat.com, namhyung@...nel.org,
 acme@...nel.org, eranian@...gle.com, mark.rutland@....com,
 alexander.shishkin@...ux.intel.com, jolsa@...nel.org, irogers@...gle.com,
 adrian.hunter@...el.com, kan.liang@...ux.intel.com, tglx@...utronix.de,
 bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 santosh.shukla@....com, ananth.narayan@....com, sandipan.das@....com,
 Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH v2 06/10] perf/amd/ibs: Add pmu specific minimum period

On 06-Dec-24 2:12 PM, Ingo Molnar wrote:
> 
> * Ravi Bangoria <ravi.bangoria@....com> wrote:
> 
>> 0x10 is the minimum sample period for IBS Fetch and 0x90 for IBS Op.
>> Current IBS pmu driver uses 0x10 for both the pmus, which is incorrect.
>> Fix it by adding pmu specific minimum period values in struct perf_ibs.
>>
>> Also, bail out opening a 'sample period mode' event if the user requested
>> sample period is less than pmu supported minimum value. For a 'freq mode'
>> event, start calibrating sample period from pmu specific minimum period.
> 
> Could you please capitalize PMU consistently, like the rest of the code 
> does, both in code comments and in changelogs?
> 
> It's "PMU" and "PMUs", not "pmu" and "pmus". The only lower case use is 
> when we mention 'struct pmu' - and that should be quoted.

Sure. Will fix that in next revision.

Thanks,
Ravi