linux-kernel - Re: [PATCH v5 1/4] ACPI: battery: Rename extensions to hook in messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <esivcfgbfewjcnvc3uhsdvxbu5dmh3r5z2hjjagzvfrxxsioav@cx2du3oznvhi>
Date: Fri, 6 Dec 2024 01:40:23 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Armin Wolf <W_Armin@....de>, Hans de Goede <hdegoede@...hat.com>, 
	Thomas Weißschuh <thomas@...ssschuh.net>, Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Len Brown <lenb@...nel.org>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	chrome-platform@...ts.linux.dev, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v5 1/4] ACPI: battery: Rename extensions to hook in
 messages

Hi,

On Thu, Dec 05, 2024 at 09:46:35PM +0100, Thomas Weißschuh wrote:
> This functionality is called "hook" everywhere in the code.
> For consistency call it the same in the log messages.
> 
> The power supply subsystem is about to get its own extension
> functionality. While the two are closely related and will be used
> together, the current wording leaves room for misinterpretation.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> 
> ---
> This patch can also be applied independently through the ACPI tree.
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

>  drivers/acpi/battery.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 3d5342f8d7b3ae4e259131f9c7b7144a6206cfdb..6760330a8af55d51c82a0447623c2040ffdaab10 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -717,7 +717,7 @@ static void battery_hook_unregister_unlocked(struct acpi_battery_hook *hook)
>  	}
>  	list_del_init(&hook->list);
>  
> -	pr_info("extension unregistered: %s\n", hook->name);
> +	pr_info("hook unregistered: %s\n", hook->name);
>  }
>  
>  void battery_hook_unregister(struct acpi_battery_hook *hook)
> @@ -751,18 +751,18 @@ void battery_hook_register(struct acpi_battery_hook *hook)
>  		if (hook->add_battery(battery->bat, hook)) {
>  			/*
>  			 * If a add-battery returns non-zero,
> -			 * the registration of the extension has failed,
> +			 * the registration of the hook has failed,
>  			 * and we will not add it to the list of loaded
>  			 * hooks.
>  			 */
> -			pr_err("extension failed to load: %s", hook->name);
> +			pr_err("hook failed to load: %s", hook->name);
>  			battery_hook_unregister_unlocked(hook);
>  			goto end;
>  		}
>  
>  		power_supply_changed(battery->bat);
>  	}
> -	pr_info("new extension: %s\n", hook->name);
> +	pr_info("new hook: %s\n", hook->name);
>  end:
>  	mutex_unlock(&hook_mutex);
>  }
> @@ -805,10 +805,10 @@ static void battery_hook_add_battery(struct acpi_battery *battery)
>  	list_for_each_entry_safe(hook_node, tmp, &battery_hook_list, list) {
>  		if (hook_node->add_battery(battery->bat, hook_node)) {
>  			/*
> -			 * The notification of the extensions has failed, to
> -			 * prevent further errors we will unload the extension.
> +			 * The notification of the hook has failed, to
> +			 * prevent further errors we will unload the hook.
>  			 */
> -			pr_err("error in extension, unloading: %s",
> +			pr_err("error in hook, unloading: %s",
>  					hook_node->name);
>  			battery_hook_unregister_unlocked(hook_node);
>  		}
> 
> -- 
> 2.47.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)