linux-kernel - Re: [PATCH v2 17/22] wifi: ath12k: add AHB driver support for IPQ5332

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f8b86fa-65d1-45ef-b363-54772e2c48ba@quicinc.com>
Date: Fri, 6 Dec 2024 15:30:07 +0530
From: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        <ath12k@...ts.infradead.org>
CC: <linux-wireless@...r.kernel.org>, Kalle Valo <kvalo@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Jeff Johnson <jjohnson@...nel.org>,
        "Bjorn
 Andersson" <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        Balamurugan S <quic_bselvara@...cinc.com>,
        "P Praneesh" <quic_ppranees@...cinc.com>
Subject: Re: [PATCH v2 17/22] wifi: ath12k: add AHB driver support for IPQ5332

On 10/19/2024 1:59 AM, Konrad Dybcio wrote:
>> +static int ath12k_ahb_start(struct ath12k_base *ab)
>> +{
>> +	ath12k_ahb_ce_irqs_enable(ab);
>> +	ath12k_ce_rx_post_buf(ab);
>> +
>> +	return 0;
>> +}
> Neither this nor ath12k_pci returns anything useful - perhaps make this void?

Thanks for the comment, this requires changes to be done also in ath12k pci and
hif_ops, hence, will take is up separately.