[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241205165011.549ea681@kernel.org>
Date: Thu, 5 Dec 2024 16:50:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Stefan Wahren <wahrenst@....net>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] qca_spi: Fix clock speed for multiple QCA7000
On Thu, 5 Dec 2024 12:07:21 +0100 Stefan Wahren wrote:
> > I think we should also delete the (seemingly unused?) qca->clkspeed
> > in this change. Otherwise it looks surprising that we still assign
> > the module param to it?
> Good catch! But shouldn't this be a separate clean-up, because the
> clkspeed was already unused before?
I'd put it in the same change for the sake of backporters.
Otherwise they may worry there was an intermediate patch,
or perhaps there even is one, I haven't checked.
If we delete the field and the assignment - if the backport
compiles its probably correct.
Powered by blists - more mailing lists