linux-kernel - Re: [EXTERNAL] Re: [PATCH net-next v3 RESEND] octeon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241205165147.2f7a7ae8@kernel.org>
Date: Thu, 5 Dec 2024 16:51:47 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Haseeb Gani
 <hgani@...vell.com>, Sathesh B Edara <sedara@...vell.com>, Vimlesh Kumar
 <vimleshk@...vell.com>, "thaller@...hat.com" <thaller@...hat.com>,
 "wizhao@...hat.com" <wizhao@...hat.com>, "kheib@...hat.com"
 <kheib@...hat.com>, "egallen@...hat.com" <egallen@...hat.com>,
 "konguyen@...hat.com" <konguyen@...hat.com>, "horms@...nel.org"
 <horms@...nel.org>, "einstein.xue@...axg.com" <einstein.xue@...axg.com>,
 Veerasenareddy Burru <vburru@...vell.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [EXTERNAL] Re: [PATCH net-next v3 RESEND] octeon_ep: add ndo
 ops for VFs in PF driver

On Thu, 5 Dec 2024 15:47:29 +0000 Shinas Rasheed wrote:
> > I don't see it ever getting set to true, why track it if it's always
> > false?
> 
> In case we need to support the api in the future, just added the
> corresponding data structure to track it. Perhaps if you think that’s
> warranted only 'when' we support it then, maybe I can remove it. The
> data structure was used to check for 'trusted' when vf tries to set
> its mac.

Yes, please remove it. We try to limit merging code that's of 
no immediate use.