linux-kernel - Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1LUoSobMwsQER9y@hovoldconsulting.com>
Date: Fri, 6 Dec 2024 11:40:33 +0100
From: Johan Hovold <johan@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Rob Clark <robdclark@...il.com>,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Sean Paul <sean@...rly.run>,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Jeykumar Sankaran <jsanka@...eaurora.org>, stable@...r.kernel.org,
	Leonard Lausen <leonard@...sen.nl>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the
 writeback connector

Hi Dmitry,

On Wed, Nov 20, 2024 at 09:39:27AM +0100, Johan Hovold wrote:
> On Fri, Aug 02, 2024 at 10:47:33PM +0300, Dmitry Baryshkov wrote:
> > During suspend/resume process all connectors are explicitly disabled and
> > then reenabled. However resume fails because of the connector_status check:
> > 
> > [ 1185.831970] [dpu error]connector not connected 3
> 
> Please also include the follow-on resume error. I'm seeing:
> 
> 	[dpu error]connector not connected 3
> 	[drm:drm_mode_config_helper_resume [drm_kms_helper]] *ERROR* Failed to resume (-22)
> 
> and say something about that this can prevent displays from being
> enabled on resume in some setups (preferably with an explanation why if
> you have one).
> 
> > It doesn't make sense to check for the Writeback connected status (and
> > other drivers don't perform such check), so drop the check.
> > 
> > Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c")
> 
> I noticed that the implementation had this status check also before
> 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to
> dpu_writeback.c").
> 
> Why did this not cause any trouble back then? Or is this not the right
> Fixes tag?
> 
> > Cc: stable@...r.kernel.org
> > Reported-by: Leonard Lausen <leonard@...sen.nl>
> > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/57
> 
> Perhaps you can include mine an György's reports here too.
> 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 
> With the above addressed:
> 
> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> Tested-by: Johan Hovold <johan+linaro@...nel.org>

It's been over two weeks and I'm still waiting on a reply from you.

Can you please respin the patch as suggested above so that we can get
this merged ASAP to fix suspend on X1E which has been broken since at
least early summer.

Johan