linux-kernel - RE: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in Microchip phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <CO1PR11MB4771E6936F63727B53F187B2E2312@CO1PR11MB4771.namprd11.prod.outlook.com>
Date: Fri, 6 Dec 2024 11:30:23 +0000
From: <Divya.Koppera@...rochip.com>
To: <andrew@...n.ch>
CC: <Arun.Ramadoss@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
	<hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<richardcochran@...il.com>, <vadim.fedorenko@...ux.dev>
Subject: RE: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library
 support and 1588 optional flag in Microchip phys

Hi Andrew,

Thanks for your comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Thursday, December 5, 2024 8:06 PM
> To: Divya Koppera - I30481 <Divya.Koppera@...rochip.com>
> Cc: Arun Ramadoss - I17769 <Arun.Ramadoss@...rochip.com>;
> UNGLinuxDriver <UNGLinuxDriver@...rochip.com>; hkallweit1@...il.com;
> linux@...linux.org.uk; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; richardcochran@...il.com;
> vadim.fedorenko@...ux.dev
> Subject: Re: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support
> and 1588 optional flag in Microchip phys
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> > > And has Microchip finial decided not to keep reinventing the wheel,
> > > and there will never be a new PHY implementation? I ask, because
> > > what would its KCONFIG symbol be?
> > >
> >
> 
> > For all future Microchip PHYs PTP IP will be same, hence the
> > implementation and kconfig symbol is under MICROCHIP_PHYPTP to keep it
> > more generic.
> 
> So you would be happy for me to NACK all new PHY PTP implementations?
> 
> Are you management happy with this statement?
> 
> Even if they are, i still think you need a less generic KCONFIG symbol, i doubt
> somebody somewhere in Microchip can resist making yet another PTP
> implementation.
> 

I understand your point.

I will change the Kconfig symbol to "MICROCHIP_PHY_RDS_PTP". RDS is internal code name to identify the PHY PTP IP. 

I will also change the file names, macros, and functions to reflect the internal code name as per macro.

>         Andrew

Thanks,
Divya