linux-kernel - Re: [PATCH v3 01/11] libnvdimm: Simplify nd_namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <288fe563-bd3b-4075-bcf6-5fc4782a6cb9@icloud.com>
Date: Fri, 6 Dec 2024 08:56:26 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Alison Schofield <alison.schofield@...el.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Uwe Kleine-König <ukleinek@...nel.org>,
 James Bottomley <James.Bottomley@...senpartnership.com>,
 Thomas Weißschuh <thomas@...ch.de>,
 linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev,
 linux-sound@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-block@...r.kernel.org, linux-cxl@...r.kernel.org,
 linux1394-devel@...ts.sourceforge.net, arm-scmi@...r.kernel.org,
 linux-efi@...r.kernel.org, linux-gpio@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
 linux-hwmon@...r.kernel.org, linux-media@...r.kernel.org,
 linux-pwm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 linux-scsi@...r.kernel.org, open-iscsi@...glegroups.com,
 linux-usb@...r.kernel.org, linux-serial@...r.kernel.org,
 netdev@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v3 01/11] libnvdimm: Simplify nd_namespace_store()
 implementation

On 2024/12/6 07:30, Alison Schofield wrote:
> On Thu, Dec 05, 2024 at 08:10:10AM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> Hi Zihun,
> 
> Similar to my comment on Patch 10/11, this commit msg can be
> explicit:
> 
> libnvdimm: Replace namespace_match() w device_find_child_by_name()
> 
>>
>> Simplify nd_namespace_store() implementation by  device_find_child_by_name()
>                                                   ^using 
> 

thank you Alison for code review.

will send v4 with your suggestions.
(^^)

> Otherwise you can add:
> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
> 
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
>> ---
>>  drivers/nvdimm/claim.c | 9 +--------
>>  1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
>> index 030dbde6b0882050c90fb8db106ec15b1baef7ca..9e84ab411564f9d5e7ceb687c6491562564552e3 100644
>> --- a/drivers/nvdimm/claim.c
>> +++ b/drivers/nvdimm/claim.c
>> @@ -67,13 +67,6 @@ bool nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach,
>>  	return claimed;
>>  }
>>  
>> -static int namespace_match(struct device *dev, void *data)
>> -{
>> -	char *name = data;
>> -
>> -	return strcmp(name, dev_name(dev)) == 0;
>> -}
>> -
>>  static bool is_idle(struct device *dev, struct nd_namespace_common *ndns)
>>  {
>>  	struct nd_region *nd_region = to_nd_region(dev->parent);
>> @@ -168,7 +161,7 @@ ssize_t nd_namespace_store(struct device *dev,
>>  		goto out;
>>  	}
>>  
>> -	found = device_find_child(dev->parent, name, namespace_match);
>> +	found = device_find_child_by_name(dev->parent, name);
>>  	if (!found) {
>>  		dev_dbg(dev, "'%s' not found under %s\n", name,
>>  				dev_name(dev->parent));
>>
>> -- 
>> 2.34.1
>>
>>