linux-kernel - Re: [PATCH] ALSA: cmipci: Modify the incorrect format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plm5rn1v.wl-tiwai@suse.de>
Date: Fri, 06 Dec 2024 13:52:28 +0100
From: Takashi Iwai <tiwai@...e.de>
To: liujing <liujing@...s.chinamobile.com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	drhodes@...nsource.cirrus.com,
	jbrunet@...libre.com,
	broonie@...nel.org,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: cmipci: Modify the incorrect format specifier

On Fri, 06 Dec 2024 03:16:47 +0100,
liujing wrote:
> 
> Replace %d with %u in snprintf() because it is "unsigned int".
> 
> Signed-off-by: liujing <liujing@...s.chinamobile.com>

I applied this one, but please keep in mind that we don't have to
convert all those cases blindly.  The code there is correct even with
"%d", as the value can't be a negative value.

That said, if you keep working on a similar case, you'd better study
the code more closely and judge whether it really "fixes" any real
bug or not, before submitting patches at the next time.

thanks,

Takashi