linux-kernel - Re: [PATCH v2 00/22] wifi: ath12k: add Ath12k AHB driver support for IPQ5332

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cda109c9-a1e2-42cb-b830-6764c6eef519@kernel.org>
Date: Fri, 6 Dec 2024 13:55:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>
Cc: ath12k@...ts.infradead.org, linux-wireless@...r.kernel.org,
 Kalle Valo <kvalo@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 00/22] wifi: ath12k: add Ath12k AHB driver support for
 IPQ5332

On 06/12/2024 12:07, Raj Kumar Bhagat wrote:
> On 10/16/2024 12:27 PM, Krzysztof Kozlowski wrote:
>> On Tue, Oct 15, 2024 at 11:56:15PM +0530, Raj Kumar Bhagat wrote:
>>> Currently, Ath12k driver only supports WiFi devices that are based on
>>> PCI bus. New Ath12k device IPQ5332 is based on AHB bus. Hence, add
>>> Ath12k AHB support for IPQ5332.
>>>
>>> IPQ5332 is IEEE802.11be 2 GHz 2x2 Wifi device. To bring-up IPQ5332
>>> device:
>>> - Add hardware parameters for IPQ5332.
>>> - CE and CMEM register address space in IPQ5332 is separate from WCSS
>>>   register space. Hence, add logic to remap CE and CMEM register
>>>   address.
>>> - Add support for fixed QMI firmware memory for IPQ5332.
>>> - Support userPD handling for WCSS secure PIL driver to enable ath12k
>>>   AHB support.
>>>
>>> Depends-On: [PATCH V7 0/5] remove unnecessary q6 clocks
>>> Depends-On: [PATCH V2 0/4] Add new driver for WCSS secure PIL loading
>>> Link: https://lore.kernel.org/all/20240820055618.267554-1-quic_gokulsri@quicinc.com/
>>> Link: https://lore.kernel.org/all/20240829134021.1452711-1-quic_gokulsri@quicinc.com/
>>
>> These are series targetting other subsystems. I do not understand why
>> you created such dependency. It does not look needed and for sure is not
>> good: nothing here can be tested, nothing can be applied.
> 
> To validate this series, the dependencies mentioned above were necessary, which
> is why they were included.

What does it mean "validate"? You are supposed to describe how upstream
can consume this.

> 
> Currently, the "[PATCH V7 0/5] remove unnecessary q6 clocks" has been merged,
> so this dependency will not be required in the next version.
> 
> The "[PATCH V2 0/4] Add new driver for WCSS secure PIL loading" series is still
> under review and is required for validation.
> 
> However, this series can still be applied and compiled without these dependencies.
> Please let us know if we should remove the dependency in the next version.

So write proper cover letter not bringing up fake dependencies.
Otherwise answer is: this cannot be tested, thus it will not be reviewed.

Best regards,
Krzysztof