linux-kernel - Re: [PATCH] regulator: axp20x: AXP717: set ramp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADomA48sOgYor3XEfBWwmqifFdE1u5sOQGR1CzzkHOAOaT_JEA@mail.gmail.com>
Date: Fri, 6 Dec 2024 14:47:16 +0100
From: Philippe Simons <simons.philippe@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Chen-Yu Tsai <wens@...e.org>, 
	"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: axp20x: AXP717: set ramp_delay

On Fri, Dec 6, 2024 at 2:44 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Fri, Dec 06, 2024 at 01:54:39PM +0100, Philippe Simons wrote:
> > On Fri, Dec 6, 2024 at 1:48 PM Mark Brown <broonie@...nel.org> wrote:
>
> > > >  static const struct regulator_desc axp717_regulators[] = {
> > > > +     AXP_DESC_RANGES_DELAY(AXP717, DCDC1, "dcdc1", "vin1",
> > > > +                     AXP717_DCDC_OUTPUT_CONTROL, BIT(0), 640),
>
> > > This doesn't seem to match with the above - ramp_delay is in units of
> > > uV/us?
>
> > 15.625 us / 10mV = 1.5625 us/mV = 0.0015625 us/uV
> > 0.0015625^-1 = 640 uV/us
>
> Ah, yes - sorry - I typed when I did the calculation.

No problem.
BTW: this patch is critical to at least Anbernic H700 based devices.
Without it, DVFS crashes very quickly.