linux-kernel - Re: [PATCH] mempolicy.h: Remove unnecessary header file inclusions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241206220037.5c0cd212d3269dd8a6f36e4d@linux-foundation.org>
Date: Fri, 6 Dec 2024 22:00:37 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Junjie Fu <fujunjie1@...com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, willy@...radead.org,
 mhocko@...e.com, gourry@...rry.net
Subject: Re: [PATCH] mempolicy.h: Remove unnecessary header file inclusions

On Fri,  6 Dec 2024 23:53:49 +0800 Junjie Fu <fujunjie1@...com> wrote:

> Originally, linux/mempolicy.h included linux/pagemap.h because vma_migratable()
> was implemented inline within the header, requiring mapping_gfp_mask()
> function to implement vma_migratable(). Now that vma_migratable() is only
> declared in linux/mempolicy.h and its implementation has been moved to mempolicy.c,
> the inclusion of linux/pagemap.h in the header is no longer necessary.
> 
> Additionally, since mempolicy.c includes internal.h, and internal.h already
> includes linux/pagemap.h, so there is no need to modify mempolicy.c after
> removing the direct inclusion of linux/pagemap.h from linux/mempolicy.h

If mempolicy.c uses things whcih are defined in pagemap.h then
mempolicy.c should include pagemap.h directly, and not rely upon such
nested includes.  It's simpler, directer, expresses what's actually
happening and avoids build breakage due to ongoing header untanglings.