linux-kernel - Re: [PATCH v1] tools/hv: reduce resouce usage in hv_get_dns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1P2kKZQuPX-LH4x@liuwe-devbox-debian-v2>
Date: Sat, 7 Dec 2024 07:17:36 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Olaf Hering <olaf@...fle.de>
Cc: linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>
Subject: Re: [PATCH v1] tools/hv: reduce resouce usage in hv_get_dns_info
 helper

On Mon, Dec 02, 2024 at 01:04:10PM +0100, Olaf Hering wrote:
> Remove the usage of cat. Replace the shell process with awk with 'exec'.
> Also use a generic shell because no bash specific features will be used.
> 
> Signed-off-by: Olaf Hering <olaf@...fle.de>

The resource saving is not a lot, but nonetheless:

Acked-by: Wei Liu <wei.liu@...nel.org>

> ---
>  tools/hv/hv_get_dns_info.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/hv/hv_get_dns_info.sh b/tools/hv/hv_get_dns_info.sh
> index 058c17b46ffc..268521234d4b 100755
> --- a/tools/hv/hv_get_dns_info.sh
> +++ b/tools/hv/hv_get_dns_info.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>  
>  # This example script parses /etc/resolv.conf to retrive DNS information.
>  # In the interest of keeping the KVP daemon code free of distro specific
> @@ -10,4 +10,4 @@
>  # this script can be based on the Network Manager APIs for retrieving DNS
>  # entries.
>  
> -cat /etc/resolv.conf 2>/dev/null | awk '/^nameserver/ { print $2 }'
> +exec awk '/^nameserver/ { print $2 }' /etc/resolv.conf 2>/dev/null
>