linux-kernel - Re: [PATCH] hv/hv_kvp_daemon: Pass NIC name to hv_get_dns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1P_naD-PjHimswj@liuwe-devbox-debian-v2>
Date: Sat, 7 Dec 2024 07:56:13 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Vitaly Kuznetsov <vkuznets@...hat.com>
Cc: linux-hyperv@...r.kernel.org, mhklinux@...look.com,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hv/hv_kvp_daemon: Pass NIC name to hv_get_dns_info as
 well

On Tue, Nov 12, 2024 at 04:04:01PM +0100, Vitaly Kuznetsov wrote:
> The reference implementation of hv_get_dns_info which is in the tree uses
> /etc/resolv.conf to get DNS servers and this does not require to know which
> NIC is queried. Distro specific implementations, however, may want to
> provide per-NIC, fine grained information. E.g. NetworkManager keeps track
> of DNS servers per connection.
> 
> Similar to hv_get_dhcp_info, pass NIC name as a parameter to
> hv_get_dns_info script.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Applied. Thanks.

> ---
>  tools/hv/hv_kvp_daemon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index ae57bf69ad4a..296a7a62c54d 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -725,7 +725,7 @@ static void kvp_get_ipconfig_info(char *if_name,
>  	 * .
>  	 */
>  
> -	sprintf(cmd, KVP_SCRIPTS_PATH "%s",  "hv_get_dns_info");
> +	sprintf(cmd, KVP_SCRIPTS_PATH "%s %s", "hv_get_dns_info", if_name);
>  
>  	/*
>  	 * Execute the command to gather DNS info.
> -- 
> 2.47.0
>