linux-kernel - Re: [PATCH v3] pinctrl: stm32: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9830993d-943b-4079-b31d-7c77ee83d306@denx.de>
Date: Sat, 7 Dec 2024 12:42:44 +0100
From: Marek Vasut <marex@...x.de>
To: Mingwei Zheng <zmw12306@...il.com>
Cc: linus.walleij@...aro.org, mcoquelin.stm32@...il.com,
 alexandre.torgue@...s.st.com, make24@...as.ac.cn, peng.fan@....com,
 fabien.dessenne@...s.st.com, linux-gpio@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH v3] pinctrl: stm32: Add check for clk_enable()

On 12/6/24 10:43 PM, Mingwei Zheng wrote:

[...]

> @@ -1646,8 +1645,8 @@ int stm32_pctl_probe(struct platform_device *pdev)
>   		if (ret) {
>   			fwnode_handle_put(child);
>   
> -			for (i = 0; i < pctl->nbanks; i++)
> -				clk_disable_unprepare(pctl->banks[i].clk);
> +			clk_bulk_disable(pctl->nbanks, pctl->clks);
> +			clk_bulk_unprepare(pctl->nbanks, pctl->clks);

Use clk_bulk_disable_unprepare()

include/linux/clk.h:static inline void clk_bulk_disable_unprepare(int 
num_clks,

It looks pretty good otherwise, thanks !