linux-kernel - Re: [PATCH v2] mm: use clear_user_(high)page() for arch with special user folio handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cfe4e6a-21e8-43ad-99e9-7209ce814d84@efficios.com>
Date: Sat, 7 Dec 2024 11:38:08 -0500
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Zi Yan <ziy@...dia.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
 Geert Uytterhoeven <geert@...ux-m68k.org>, Vlastimil Babka <vbabka@...e.cz>,
 David Hildenbrand <david@...hat.com>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Miaohe Lin <linmiaohe@...wei.com>, Kefeng Wang <wangkefeng.wang@...wei.com>,
 John Hubbard <jhubbard@...dia.com>,
 "Huang, Ying" <ying.huang@...ux.alibaba.com>,
 Ryan Roberts <ryan.roberts@....com>, Alexander Potapenko
 <glider@...gle.com>, Kees Cook <keescook@...omium.org>,
 Vineet Gupta <vgupta@...nel.org>, linux-kernel@...r.kernel.org,
 Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH v2] mm: use clear_user_(high)page() for arch with special
 user folio handling

On 2024-12-07 11:20, Zi Yan wrote:
> On 7 Dec 2024, at 10:31, Mathieu Desnoyers wrote:
[...]
>> I'm not entirely sure if we want to go for the wording "is_aliasing"
>> or "is_incoherent" when talking about icache vs dcache, so I'm open
>> to ideas here.
>>
> 
> Let me know if the code below looks good to you. I will use
> (cpu_icache_is_aliasing() || cpu_dcache_is_aliasing())
> instead of
> (cpu_dcache_is_aliasing() || IS_ENABLED(CONFIG_ARC))
> in my next version.

Yes, this is in line with what I have in mind.

And I prefer your second version with the generic
cpu_icache_is_aliasing rather than defining it for
each architecture.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com