linux-kernel - Re: [PATCH] mm/mempolicy.c: include pagemap.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1SCZlMcjBCzHOxf@casper.infradead.org>
Date: Sat, 7 Dec 2024 17:14:14 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Junjie Fu <fujunjie1@...com>
Cc: akpm@...ux-foundation.org, gourry@...rry.net,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, mhocko@...e.com
Subject: Re: [PATCH] mm/mempolicy.c: include pagemap.h directly

On Sat, Dec 07, 2024 at 04:14:30PM +0800, Junjie Fu wrote:
> @@ -113,7 +113,7 @@
>  #include <asm/tlbflush.h>
>  #include <asm/tlb.h>
>  #include <linux/uaccess.h>
> -
> +#include <linux/pagemap.h>
>  #include "internal.h"

This is in the wrong place.  The linux/ includes go before the asm/
includes.  I like to stick to alphabetical order within that divide,
but other people have other preferences.