linux-kernel - Re: [PATCH] regulator: axp20x: AXP717: set ramp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67548894.050a0220.2032bf.693e@mx.google.com>
Date: Sat, 7 Dec 2024 11:40:35 -0600
From: Chris Morgan <macroalpha82@...il.com>
To: Philippe Simons <simons.philippe@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Chen-Yu Tsai <wens@...e.org>,
	"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: axp20x: AXP717: set ramp_delay

On Fri, Dec 06, 2024 at 01:37:51PM +0100, Philippe Simons wrote:
> AXP717 datasheet says that regulator ramp delay is 15.625 us/step,
> which is 10mV in our case.
> 
> Add a AXP_DESC_RANGES_DELAY macro and update AXP_DESC_RANGES macro to
> expand to AXP_DESC_RANGES_DELAY with ramp_delay = 0
> 
> Signed-off-by: Philippe Simons <simons.philippe@...il.com>
> ---
>  drivers/regulator/axp20x-regulator.c | 23 +++++++++++++++--------
>  1 file changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index a8e91d9d0..8f035db13 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -419,8 +419,8 @@
>  		.ops		= &axp20x_ops_fixed				\
>  	}
>  
> -#define AXP_DESC_RANGES(_family, _id, _match, _supply, _ranges, _n_voltages,	\
> -			_vreg, _vmask, _ereg, _emask)				\
> +#define AXP_DESC_RANGES_DELAY(_family, _id, _match, _supply, _ranges, _n_voltages,	\
> +			_vreg, _vmask, _ereg, _emask, _ramp_delay)	\
>  	[_family##_##_id] = {							\
>  		.name		= (_match),					\
>  		.supply_name	= (_supply),					\
> @@ -437,8 +437,15 @@
>  		.linear_ranges	= (_ranges),					\
>  		.n_linear_ranges = ARRAY_SIZE(_ranges),				\
>  		.ops		= &axp20x_ops_range,				\
> +		.ramp_delay = (_ramp_delay),			\
>  	}
>  
> +#define AXP_DESC_RANGES(_family, _id, _match, _supply, _ranges, _n_voltages,	\
> +			_vreg, _vmask, _ereg, _emask)				\
> +	AXP_DESC_RANGES_DELAY(_family, _id, _match, _supply, _ranges, _n_voltages,	\
> +		_vreg, _vmask, _ereg, _emask, 0)
> +
> +
>  static const int axp209_dcdc2_ldo3_slew_rates[] = {
>  	1600,
>  	 800,
> @@ -781,18 +788,18 @@ static const struct linear_range axp717_dcdc3_ranges[] = {
>  };
>  
>  static const struct regulator_desc axp717_regulators[] = {
> -	AXP_DESC_RANGES(AXP717, DCDC1, "dcdc1", "vin1",
> +	AXP_DESC_RANGES_DELAY(AXP717, DCDC1, "dcdc1", "vin1",
>  			axp717_dcdc1_ranges, AXP717_DCDC1_NUM_VOLTAGES,
>  			AXP717_DCDC1_CONTROL, AXP717_DCDC_V_OUT_MASK,
> -			AXP717_DCDC_OUTPUT_CONTROL, BIT(0)),
> -	AXP_DESC_RANGES(AXP717, DCDC2, "dcdc2", "vin2",
> +			AXP717_DCDC_OUTPUT_CONTROL, BIT(0), 640),
> +	AXP_DESC_RANGES_DELAY(AXP717, DCDC2, "dcdc2", "vin2",
>  			axp717_dcdc2_ranges, AXP717_DCDC2_NUM_VOLTAGES,
>  			AXP717_DCDC2_CONTROL, AXP717_DCDC_V_OUT_MASK,
> -			AXP717_DCDC_OUTPUT_CONTROL, BIT(1)),
> -	AXP_DESC_RANGES(AXP717, DCDC3, "dcdc3", "vin3",
> +			AXP717_DCDC_OUTPUT_CONTROL, BIT(1), 640),
> +	AXP_DESC_RANGES_DELAY(AXP717, DCDC3, "dcdc3", "vin3",
>  			axp717_dcdc3_ranges, AXP717_DCDC3_NUM_VOLTAGES,
>  			AXP717_DCDC3_CONTROL, AXP717_DCDC_V_OUT_MASK,
> -			AXP717_DCDC_OUTPUT_CONTROL, BIT(2)),
> +			AXP717_DCDC_OUTPUT_CONTROL, BIT(2), 640),
>  	AXP_DESC(AXP717, DCDC4, "dcdc4", "vin4", 1000, 3700, 100,
>  		 AXP717_DCDC4_CONTROL, AXP717_DCDC_V_OUT_MASK,
>  		 AXP717_DCDC_OUTPUT_CONTROL, BIT(3)),
> -- 
> 2.47.1
> 

This series solves the immediate crashes I get on startup when I use
schedutil as my cpu scheduler.

Tested-by: Chris Morgan <macromorgan@...mail.com>