linux-kernel - Re: [PATCH] ubifs/debug: remove return from end of void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOuPNLgPmq6DyjQVQkmRi3Ap8UXURaU7w_g_zJ3yzheaNNZa2A@mail.gmail.com>
Date: Sat, 7 Dec 2024 23:33:08 +0530
From: Pintu Agarwal <pintu.ping@...il.com>
To: Zhihao Cheng <chengzhihao1@...wei.com>
Cc: Pintu Kumar <quic_pintu@...cinc.com>, richard@....at, linux-mtd@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] ubifs/debug: remove return from end of void function

Hi Zhihao,

On Sat, 7 Dec 2024 at 08:25, Zhihao Cheng <chengzhihao1@...wei.com> wrote:
>
> 在 2024/12/6 20:52, Pintu Kumar 写道:
> > Noticed that there is a useless return statement at the end of void
> > function ubifs_dump_leb().
> > Just removed it.
> >
> > Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>
> > ---
> >   fs/ubifs/debug.c | 1 -
> >   1 file changed, 1 deletion(-)
>
> Hi, Pintu. The title of the patch should be something like "ubifs:
> ubifs_dump_leb: remove return at end of void function". See
> Documentation/process/submitting-patches.rst. Otherwise,
>
> Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>
>
Thank you so much for your review and comments.
Oh, normally I follow "subsystem: filename: <title>" for the other patches.
Okay, no worries, I can follow your suggestion as "subsystem: function-name"
and push changes again for both the patches.

Actually, sometimes, function-name can be quite big, so I avoid it in
subject titles.
But no issues, I can change it and push again.

Thank you,
Regards,
Pintu