linux-kernel - Re: [PATCH v4 2/3] dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB PCIe Root Port Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173359624973.3074604.14570615251365278218.robh@kernel.org>
Date: Sat, 07 Dec 2024 12:30:51 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@....com>
Cc: linux-pci@...r.kernel.org, conor+dt@...nel.org, michal.simek@....com, 
 bhelgaas@...gle.com, manivannan.sadhasivam@...aro.org, 
 linux-kernel@...r.kernel.org, lpieralisi@...nel.org, krzk+dt@...nel.org, 
 devicetree@...r.kernel.org, bharat.kumar.gogada@....com, 
 jingoohan1@...il.com, kw@...ux.com
Subject: Re: [PATCH v4 2/3] dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB
 PCIe Root Port Bridge


On Sat, 07 Dec 2024 22:41:33 +0530, Thippeswamy Havalige wrote:
> Add AMD Versal2 MDB (Multimedia DMA Bridge) PCIe Root Port Bridge.
> 
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@....com>
> ---
> Changes in v2:
> -------------
> - Modify patch subject.
> - Add pcie host bridge reference.
> - Modify filename as per compatible string.
> - Remove standard PCI properties.
> - Modify interrupt controller description.
> - Indentation
> 
> Changes in v3:
> -------------
> - Modified SLCR to lower case.
> - Add dwc schemas.
> - Remove common properties.
> - Move additionalProperties below properties.
> - Remove ranges property from required properties.
> - Drop blank line.
> - Modify pci@ to pcie@
> 
> Changes in v4:
> --------------
> - None.
> ---
>  .../bindings/pci/amd,versal2-mdb-host.yaml    | 121 ++++++++++++++++++
>  1 file changed, 121 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/amd,versal2-mdb-host.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/amd,versal2-mdb-host.example.dtb: pcie@...31000: reg-names:0: 'oneOf' conditional failed, one must be fixed:
	'dbi' was expected
	'dbi2' was expected
	'mdb_pcie_slcr' is not one of ['elbi', 'app']
	'atu' was expected
	'dma' was expected
	'phy' was expected
	'config' was expected
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/amd,versal2-mdb-host.example.dtb: pcie@...31000: reg-names:0: 'oneOf' conditional failed, one must be fixed:
		'mdb_pcie_slcr' is not one of ['apb', 'mgmt', 'link', 'ulreg', 'appl']
		'mdb_pcie_slcr' is not one of ['atu_dma']
		'mdb_pcie_slcr' is not one of ['smu', 'mpu']
		'mdb_pcie_slcr' is not one of ['ecam']
		['mdb_pcie_slcr'] was expected
	from schema $id: http://devicetree.org/schemas/pci/amd,versal2-mdb-host.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241207171134.3253027-3-thippeswamy.havalige@amd.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.