linux-kernel - Re: [PATCH] rust: macros: add authors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241207014710.447144-1-trintaeoitogc@gmail.com>
Date: Fri,  6 Dec 2024 22:47:10 -0300
From: guilherme giacomo simoes <trintaeoitogc@...il.com>
To: miguel.ojeda.sandonis@...il.com
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	aliceryhl@...gle.com,
	benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	fujita.tomonori@...il.com,
	gary@...yguo.net,
	linux-kernel@...r.kernel.org,
	ojeda@...nel.org,
	rust-for-linux@...r.kernel.org,
	tahbertschinger@...il.com,
	tmgross@...ch.edu,
	trintaeoitogc@...il.com,
	walmeida@...rosoft.com,
	wcampbell1995@...il.com
Subject: Re: [PATCH] rust: macros: add authors

Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrotes:
> I understand what you mean, but changing a few existing lines here and
> there is fine. There aren't that many modules out there. If we are
> going to change this, then the best time is now. Backporting should
> not be too bad either.
Yeah, in the truth, don't have file a lot for changes.

> Sorry, I am not sure I understand what you mean. Yes, the idea of this
> option is to repeat one line per author, but that is not a big deal: C
> modules do that already.
I understand that in the C side is already this way, but maybe we have a better
way for make this.

I'm think about this, and for me, the less the developer need a think about
"what field I need use in this problem" is better. This is not because is really
difficult think about "I need use author or authors", but if we can avoid, I
think that is better. 

Well .. that said, after your tips, I change my mind and how we don't have file
a lot for change the type authors, maybe the better way is a unique field
called "authors" and this should ever be array. 

If my module have a unique author, so `authors: ["author"]`, if the module have
two or more authors, so `authors: ["author_1", "author_2", "author_n"]`. With
this way, the module developers just have a one way to declare the author of
module. Don't have different fields, don't have different types. Have a only
one way for declare the authors of module.  

Thoughts? 
You think that we need open a chat in zulipchat for this, and collect more
opinions?