linux-kernel - Re: [PATCH] ubifs/lpt_commit: remove return at end of void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abe79e0a-a35f-0b53-bbec-7d642f592fae@huawei.com>
Date: Sat, 7 Dec 2024 10:54:47 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: Pintu Kumar <quic_pintu@...cinc.com>, <richard@....at>,
	<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC: <skhan@...uxfoundation.org>, <pintu.ping@...il.com>
Subject: Re: [PATCH] ubifs/lpt_commit: remove return at end of void function

在 2024/12/6 21:05, Pintu Kumar 写道:
> Noticed that there is a useless return statement at the end of void
> function dump_lpt_leb().
> Just removing it.
> 
> Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>
> ---
>   fs/ubifs/lpt_commit.c | 1 -
>   1 file changed, 1 deletion(-)

Hi, Pintu. The title of the patch should be something like "ubifs: 
dump_lpt_leb: remove return at end of void function". See 
Documentation/process/submitting-patches.rst. Otherwise,

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>

> 
> diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
> index aa8837e6247c..f2cb214581fd 100644
> --- a/fs/ubifs/lpt_commit.c
> +++ b/fs/ubifs/lpt_commit.c
> @@ -1932,7 +1932,6 @@ static void dump_lpt_leb(const struct ubifs_info *c, int lnum)
>   	pr_err("(pid %d) finish dumping LEB %d\n", current->pid, lnum);
>   out:
>   	vfree(buf);
> -	return;
>   }
>   
>   /**
>