linux-kernel - RE: Re: [PATCH] extcon: Remove deadcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241207045814epcms1p21e267fe70a87d06cdd4c531248f193e9@epcms1p2>
Date: Sat, 07 Dec 2024 13:58:14 +0900
From: MyungJoo Ham <myungjoo.ham@...sung.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>, Chanwoo Choi
	<cw00.choi@...sung.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH] extcon: Remove deadcode

From: Dr. David Alan Gilbert / linux@...blig.org
>* linux@...blig.org (linux@...blig.org) wrote:
>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>> 
>> extcon_get_edev_name() has been unused since it was added in 2015 by
>> commit 707d7550875a ("extcon: Add extcon_get_edev_name() API to get the
>> extcon device name")
>> 
>> extcon_get_property_capability() has been unused since it was added
>> in 2016 by
>> commit ceaa98f442cf ("extcon: Add the support for the capability of each
>> property")
>> (It seems everyone just uses extcon_get_property)
>> 
>> extcon_set_property_sync() has been unused since it was added in 2016
>> by
>> commit a580982f0836 ("extcon: Add the synchronization extcon APIs to
>> support the notification")
>> Everyone seems to use the none _sync version, and there's one place
>> where they just call sync after it.
>> 
>> Remove them.
>> 
>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>
>Gentle ping please; no rush.
>
>Dave

It's not a dead code.

Example: https://github.com/diphons/D8G_Kernel_oxygen/blob/b0717c360f5485badf824fb51cdc8174e2e0a7cb/drivers/usb/dwc3/dwc3-msm.c#L2992

There are drivers (usually .ko) using them, usually Android mobile devices.

Cheers,
MyungJoo