linux-kernel - RE: Re: [PATCH] PM / devfreq: Remove unused devm_devfreq_(un)register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241207052209epcms1p45818db425ba84821003b6d735bc0e957@epcms1p4>
Date: Sat, 07 Dec 2024 14:22:09 +0900
From: MyungJoo Ham <myungjoo.ham@...sung.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
CC: Kyungmin Park <kyungmin.park@...sung.com>, Chanwoo Choi
	<cw00.choi@...sung.com>, "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH] PM / devfreq: Remove unused
 devm_devfreq_(un)register_notifier

>* linux@...blig.org (linux@...blig.org) wrote:
>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>> 
>> devm_devfreq_register_notifier() and devm_devfreq_unregister_notifier()
>> have been unused since 2019's
>> commit 0ef7c7cce43f ("PM / devfreq: passive: Use non-devm notifiers")
>> 
>> Remove them, and the helpers they used.
>> 
>> Note, devm_devfreq_register_notifier() is still used as an example
>> in Documentation/doc-guide/contributing.rst but that's just
>> an example of an old doc bug rather than anything about the function
>> itself.
>> 
>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>
>Ping.
>
>Thanks,
>
>Dave

When I search github, it appears that vendors are using this API.


NVIDIA:
https://github.com/NX-Development/android_kernel_nvidia_nvidia/blob/c9ade3b5e32a12b8cf6f33a632dc39209194e4e8/drivers/devfreq/governor_wmark_active.c#L624

Samsung:
https://github.com/Vaz15k/android_kernel_samsung_a54x/blob/8ac517c37c606746213064857dc240e99eba80d2/drivers/soc/samsung/exynos-llcgov.c#L107

Realtek:
https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/25f5b88ec4ba34029f964693dc34028b26e6c67c/linux-rtk/drivers/devfreq/realtek/governor_rtk_ltl.c#L114



Please don't remove ABIs used by vendors even if
they didn't upstream their drivers.

Cheers,
MyungJoo.