linux-kernel - Re: [PATCH] PM / devfreq: event: Call of_node_put() only once in devfreq_event_get_edev_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH3jRPZrepiS31GzXpr26xser9hdQmBcnXbsr1O7VoY0yA@mail.gmail.com>
Date: Sun, 8 Dec 2024 21:36:29 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-pm@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>, 
	Kyungmin Park <kyungmin.park@...sung.com>, MyungJoo Ham <myungjoo.ham@...sung.com>, 
	LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: event: Call of_node_put() only once in devfreq_event_get_edev_by_phandle()

Hi,

Applied it. Thanks.

On Thu, Oct 3, 2024 at 6:15 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 3 Oct 2024 11:01:30 +0200
>
> An of_node_put(node) call was immediately used after a null pointer check
> for the local variable “edev” at the end of this function implementation.
> Thus call such a function only once instead directly before the check.
>
> This issue was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/devfreq/devfreq-event.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
> index 3ebac2496679..70219099c604 100644
> --- a/drivers/devfreq/devfreq-event.c
> +++ b/drivers/devfreq/devfreq-event.c
> @@ -244,13 +244,9 @@ struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(struct device *dev,
>         edev = NULL;
>  out:
>         mutex_unlock(&devfreq_event_list_lock);
> -
> -       if (!edev) {
> -               of_node_put(node);
> -               return ERR_PTR(-ENODEV);
> -       }
> -
>         of_node_put(node);
> +       if (!edev)
> +               return ERR_PTR(-ENODEV);
>
>         return edev;
>  }
> --
> 2.46.1
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics