linux-kernel - Re: [PATCH] PM / devfreq: Remove unused devm_devfreq_(un)register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGTfZH3YkBOruDcqj8gAy0jVzdsESJo0ntL4SF9ooR_QiFjgVA@mail.gmail.com>
Date: Sun, 8 Dec 2024 21:52:44 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>, 
	Chanwoo Choi <cw00.choi@...sung.com>, 
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, 
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / devfreq: Remove unused devm_devfreq_(un)register_notifier

On Sat, Dec 7, 2024 at 9:47 PM Dr. David Alan Gilbert <linux@...blig.org> wrote:
>
> * MyungJoo Ham (myungjoo.ham@...sung.com) wrote:
> > >* linux@...blig.org (linux@...blig.org) wrote:
> > >> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > >>
> > >> devm_devfreq_register_notifier() and devm_devfreq_unregister_notifier()
> > >> have been unused since 2019's
> > >> commit 0ef7c7cce43f ("PM / devfreq: passive: Use non-devm notifiers")
> > >>
> > >> Remove them, and the helpers they used.
> > >>
> > >> Note, devm_devfreq_register_notifier() is still used as an example
> > >> in Documentation/doc-guide/contributing.rst but that's just
> > >> an example of an old doc bug rather than anything about the function
> > >> itself.
> > >>
> > >> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > >
> > >Ping.
> > >
> > >Thanks,
> > >
> > >Dave
> >
> > When I search github, it appears that vendors are using this API.
>
> Hmm OK.
> Of course there's a lot of random junk on github, so it can be tricky
> to know what's current/real/relevant.
>
> > NVIDIA:
> > https://github.com/NX-Development/android_kernel_nvidia_nvidia/blob/c9ade3b5e32a12b8cf6f33a632dc39209194e4e8/drivers/devfreq/governor_wmark_active.c#L624
> >
> > Samsung:
> > https://github.com/Vaz15k/android_kernel_samsung_a54x/blob/8ac517c37c606746213064857dc240e99eba80d2/drivers/soc/samsung/exynos-llcgov.c#L107
> >
> > Realtek:
> > https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/25f5b88ec4ba34029f964693dc34028b26e6c67c/linux-rtk/drivers/devfreq/realtek/governor_rtk_ltl.c#L114
> >
> >
> >
> > Please don't remove ABIs used by vendors even if
> > they didn't upstream their drivers.
>
> Hmm OK.
> Do you think they should be using this ABI or do they have the same bug as
> is fixed in 0ef7c7cce43f ?
> I guess they don't care.


According to Myungjoo's comment, I'll keep this code.


Thanks,


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics