linux-kernel - Re: [PATCH] mfd: intel_soc_pmic_chtdc_ti: Remove invalid max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81b7ac42-449b-43be-9bb1-e1c7ba6639f3@redhat.com>
Date: Sun, 8 Dec 2024 16:00:20 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_chtdc_ti: Remove invalid max_register
 from regmap-config

Hi Andy,

On 5-Dec-24 9:19 AM, Andy Shevchenko wrote:
> On Wed, Dec 04, 2024 at 10:02:09PM +0100, Hans de Goede wrote:
>> The max_register = 128 setting in the regmap config is not valid.
>>
>> The Intel Dollar Cove TI PMIC has an eeprom unlock register at address 0x88
>> and a number of EEPROM registers at 0xF?. Drop the invalid max_register
>> setting so that these registers can be accessed.
> 
> Wouldn't this break debugfs facility?
> If that is the case, perhaps adding 0xff to it would make more sense?

Ah you are right, I assumed not setting it would just make the regmap
code interpret things as being no maximum. But this does need to be set
for the debugfs regmap dumping to work. I did not realize that.

I'll post a v2 setting it to 0xff instead.

Regards,

Hans