linux-kernel - Re: [[PATCH] MTD: fix slab-use-after-free due to dangling pointer in notifier chain] MTD: fix slab-use-after-free due to dangling pointer in notifier chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGZfcdneGPsAwUZmC6Wv7BWSaQw2rkjDby9nhZFweYOgXvNDbw@mail.gmail.com>
Date: Sun, 8 Dec 2024 12:21:04 -0500
From: Dennis Lam <dennis.lamerice@...il.com>
To: richard@....at, chengzhihao1@...wei.com, miquel.raynal@...tlin.com, 
	vigneshr@...com
Cc: syzkaller-bugs@...glegroups.com, 
	syzbot+0988a383ae7c57b99dd9@...kaller.appspotmail.com, 
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [[PATCH] MTD: fix slab-use-after-free due to dangling pointer in
 notifier chain] MTD: fix slab-use-after-free due to dangling pointer in
 notifier chain

On Sun, Dec 8, 2024 at 3:51 AM Dennis Lam <dennis.lamerice@...il.com> wrote:
>
> When attaching MTDs, a reboot notifier is added to the blocking
> notification chain. However, when detaching a MTD and freeing its
> related objects, the notifier is never unregistered from the
> notification chain. Thus, when the chain is iterated there is a
> possibility of finding the address of the reboot notifier which has
> already been freed, resulting in a slab-use-after-free error.
>
> To fix this, I added an unregister notifier function in the ubi_wl_close
> function to ensure that the notifier is removed from the chain after the
> device has been detached.
>
> Reported-by: syzbot+0988a383ae7c57b99dd9@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/all/67409091.050a0220.363a1b.013d.GAE@google.com/T/
> Signed-off-by: Dennis Lam <dennis.lamerice@...il.com>
> ---
>  drivers/mtd/ubi/wl.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index 4f6f339d8fb8..31a1e5515d98 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -1995,6 +1995,7 @@ static void protection_queue_destroy(struct ubi_device *ubi)
>  void ubi_wl_close(struct ubi_device *ubi)
>  {
>         dbg_wl("close the WL sub-system");
> +       unregister_reboot_notifier(&ubi->wl_reboot_notifier);
>         ubi_fastmap_close(ubi);
>         shutdown_work(ubi);
>         protection_queue_destroy(ubi);
> --
> 2.47.0
>

My apologies everyone, please ignore this email. My mailing script
seems to have changed my email header and commit message. I will send
another better formatted email later.