linux-kernel - Re: [PATCH v2 6/6] arm64: dts: qcom: sm8150-microsoft-surface-duo: fix typos in da7280 properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <sgcfb6mz6hdnpbbq3lz2jyoehpgukqqv2p4kpiisrbfe44y6t5@gzpot5gpfen7>
Date: Sun, 8 Dec 2024 07:32:06 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: qcom: sm8150-microsoft-surface-duo:
 fix typos in da7280 properties

On Fri, Dec 06, 2024 at 11:12:58AM +0100, Neil Armstrong wrote:
> The dlg,const-op-mode & dlg,periodic-op-mode were mis-names with twice
> the "dlg," prefix, drop one to match the bindings.
> 
> This fixes:
> sm8150-microsoft-surface-duo.dtb: da7280@4a: 'dlg,const-op-mode' is a required property
> 	from schema $id: http://devicetree.org/schemas/input/dlg,da7280.yaml#
> m8150-microsoft-surface-duo.dtb: da7280@4a: 'dlg,periodic-op-mode' is a required property
> 	from schema $id: http://devicetree.org/schemas/input/dlg,da7280.yaml#
> sm8150-microsoft-surface-duo.dtb: da7280@4a: 'dlg,dlg,const-op-mode', 'dlg,dlg,periodic-op-mode' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/input/dlg,da7280.yaml#
> 
> With the dlg,da7280.yaml converted from dlg,da7280.txt at [1].
> 
> [1] https://lore.kernel.org/all/20241206-topic-misc-da7280-convert-v2-1-1c3539f75604@linaro.org/
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Fixes: d1f781db47a8 ("arm64: dts: qcom: add initial device-tree for Microsoft Surface Duo")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
> index b039773c44653ae8cd5c2b9fdeccbd304ad2c9e5..a1323a8b8e6bfb556a2d6d865f8b560bd6c4d429 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
> @@ -376,8 +376,8 @@ da7280@4a {
>  		pinctrl-0 = <&da7280_intr_default>;
>  
>  		dlg,actuator-type = "LRA";
> -		dlg,dlg,const-op-mode = <1>;
> -		dlg,dlg,periodic-op-mode = <1>;
> +		dlg,const-op-mode = <1>;
> +		dlg,periodic-op-mode = <1>;
>  		dlg,nom-microvolt = <2000000>;
>  		dlg,abs-max-microvolt = <2000000>;
>  		dlg,imax-microamp = <129000>;
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry